Retrofits all 39 skills to ADR-0020's description/body context contract, then fixes what six rounds of independent review found in that retrofit — including four ways the hot gate itself failed open. Closes #99, #107, #108, #110, #111, #114, #115, #120. ## The retrofit (waves 1-5) | | Start | Now | |---|---|---| | Description FAILs (>400 chars) | 26 | **0** | | Body FAILs (>900 words, body-only) | 9 | **0** | | Dangling routing targets | 2 | **0** | | `Kyberforge.CompositionNote` | 10 | **0** | | Preload tax | 21,005 chars | **~10,500** | Under the 12,000-char success criterion. Per-wave detail is on #99. ## The review fixes **The gate failed open four ways, three of them found after the retrofit shipped.** An unrecognised follower token made a dangling target vanish. A skill directory with no `SKILL.md` resolved as a valid target, so a commit could be green locally and red in a fresh clone — three existing fixtures were relying on that, one of which made the install-leak A/B pass vacuously. Then the free-standing `/name` sweep turned out to be gated on the sentence carrying a boundary marker, so route notation in any other sentence was invisible — not an ERROR, not a SUGGESTION, not an INFO — which left the documented "`/name` always blocks" promise false from a second direction. All four fixed and pinned. **Two checks were silently not running.** `validate-provenance.sh` checks 7-8 were dead across nine skills. Waking them exposed a deeper problem: they assume `Research doc:` names a source index, but 30 of 121 entries point at topic content documents, so every new check-7 INFO was a false positive and check 8 was saved from a false-FAIL flood only by an *unannounced* skip. Checks 7/8 are now scoped to source indexes and every skip announces itself (#121). **The retrofit's own anti-goal, four times.** ADR-0020 warns that a blunt gate gets satisfied by deleting content rather than relocating it. `diagnose` and `skill-audit` relocated prose and then read it unconditionally; `prototype` and `vale-config` deleted rules outright that survived nowhere. All four addressed. ## Verification - `bash tests/run-tests.sh --strict` — 24 suites, 0 skipped, 0 failed - `bash tests/run-bats.sh` — 325 tests, 0 failures - `pre-commit run --all-files` — 17/17 - `pre-commit run --hook-stage pre-push --all-files` — 16/16, with `apm marketplace check` and `apm pack --check-clean` run against the remote, not skipped - `scripts/skill-size-check.sh` over all 39 skills — rc 0, 0 ERROR/FAIL, SUGGESTION-only - Preload tax measured at **10,498 chars**, max description 390 — both inside budget - Every new test proven non-vacuous by a deliberate mutation of the behaviour it covers **Per-commit sync, stated accurately:** the ten commits from the latest review round each pass `check-plugin-content-sync` in isolation, verified by checking each out in a detached worktree with a clean between. The earlier gitea window (`dfacf05..bedbd1d`, nine commits) does **not** — its mirror was regenerated in one batch at `bbc7300`. An earlier revision of this description claimed the property held for every commit; it does not, and a bisect through that window lands on a red commit. **Squash-merge** to collapse it, or accept that this range is not bisectable. ## Version bump Six plugins and the catalog take a **patch**, not a minor. The branch is **89 commits — 40 `fix` / 30 `refactor` / 12 `docs` / 5 `chore` / 2 `test` — zero `feat`, zero `!`, zero `BREAKING CHANGE`** — and adds no skill, agent, command or hook. (Two earlier revisions of this section cited a stale histogram, most recently 78 commits; the figures above are measured at HEAD.) Both rules this repo ships (`forge/references/version-bump.md`, landing in this PR, and `git-commits/references/conventional-commits-spec.md`) make that a patch, and the catalog set is unchanged at 7 entries. Not settled by that: four published files were removed from the installed tree, three moved, and `caveman` gained `disable-model-invocation`, retiring its old triggers. Under a strict reading those are major-class and currently ship under `refactor:` with no marker. Whether the deployed skill surface is a public contract is written down nowhere — worth deciding, but it outlives this PR. ## Deliberately not in scope #112 (cherry-pick ownership, now resolved in favour of `git-commits`), #113 (`rtk git` normalisation), #116 (research fan-out), #101 (audit-skill merge), #122 (non-spec skill-root files), #123 (no PRD producer) stay open. #117 is the one worth reading: the contract's remedy is to move prose into `references/`, which is exactly where neither the size gate nor Vale looks — and the blind spot is wider than #117 currently records, since there is no root `.vale.ini` at all, so every ADR, `CONTEXT.md` and `README.md` is unlinted too. That blind spot let this branch carry two `level: error` `Kyberforge.SentenceOpenerThereIs` violations into `references/` files it created — `provider-adapter-author/references/provider-matrix.md:31` and `agent-audit/references/finding-criteria.md:95`. Both are reworded in `afadaae`, confirmed by routing each file through the audit's own `vale-wrap.sh` (1 error each before, 0 after). Five further occurrences sit in `references/` files already on `main`; those are the pre-existing corpus and stay with #117, which is the real fix. Also unfixed and not this PR's: `apm install` appends a duplicate `SessionStart` entry to `.claude/settings.json`, so a fresh clone cannot get pre-push green without an edit AGENTS.md warns against. Reproduces identically on `main`. Co-authored-by: Defame1297 <gitea@rkdr.net> Reviewed-on: https://git.dev.rkdr.net/Defame1297/holocron/pulls/129 Co-authored-by: Claude Code AI - Gitea MCP <claude@noreply.git.dev.rkdr.net> Co-committed-by: Claude Code AI - Gitea MCP <claude@noreply.git.dev.rkdr.net>
6.5 KiB
source_keys
| source_keys | ||||
|---|---|---|---|---|
|
Hook Recommendations by Language / Context
Use this table when creating a config from scratch or recommending hooks to add. Always check the existing config for duplicates before proposing.
Fixer hooks (trailing-whitespace, end-of-file-fixer, pretty-format-json and the like) rewrite
files but do NOT re-stage them, so the commit is still blocked and the user has to stage and commit
again. Say so when proposing one — otherwise the first blocked commit reads as the hook being
broken.
Universal (recommend for every repo)
| Hook ID | Repo | Rev | Rationale |
|---|---|---|---|
end-of-file-fixer |
https://github.com/pre-commit/pre-commit-hooks |
v6.0.0 |
Ensures files end with a newline — prevents spurious diffs |
trailing-whitespace |
https://github.com/pre-commit/pre-commit-hooks |
v6.0.0 |
Strips trailing whitespace — prevents invisible diff noise |
check-merge-conflict |
https://github.com/pre-commit/pre-commit-hooks |
v6.0.0 |
Catches unresolved merge markers before commit |
detect-private-key |
https://github.com/pre-commit/pre-commit-hooks |
v6.0.0 |
Blocks PEM private key material |
check-added-large-files |
https://github.com/pre-commit/pre-commit-hooks |
v6.0.0 |
Blocks accidentally committing large binary files |
check-case-conflict |
https://github.com/pre-commit/pre-commit-hooks |
v6.0.0 |
Catches filenames that would collide on case-insensitive filesystems |
mixed-line-ending |
https://github.com/pre-commit/pre-commit-hooks |
v6.0.0 |
Normalizes line endings |
no-commit-to-branch |
https://github.com/pre-commit/pre-commit-hooks |
v6.0.0 |
Blocks direct commits to protected branches — defaults to blocking main+master with no args; add args: [--branch, <name>] only to protect additional branch names |
Shell (.sh)
| Hook ID | Repo | Rev | Rationale |
|---|---|---|---|
shellcheck |
https://github.com/jumanjihouse/pre-commit-hooks |
3.0.0 |
Unverified — not in research corpus, verify upstream before use. Static analysis for shell scripts; catches common errors |
Recommended args: args: [--severity=warning]
Python (.py)
| Hook ID | Repo | Rev | Rationale |
|---|---|---|---|
check-ast |
https://github.com/pre-commit/pre-commit-hooks |
v6.0.0 |
Validates Python files parse as valid AST |
check-builtin-literals |
https://github.com/pre-commit/pre-commit-hooks |
v6.0.0 |
Enforces literal syntax for dict(), list() |
For formatting: check if black, ruff, or isort is already configured in pyproject.toml before recommending them.
JSON (.json)
| Hook ID | Repo | Rev | Rationale |
|---|---|---|---|
check-json |
https://github.com/pre-commit/pre-commit-hooks |
v6.0.0 |
Validates JSON parses correctly |
pretty-format-json |
https://github.com/pre-commit/pre-commit-hooks |
v6.0.0 |
Auto-formats JSON (fixer — warns user to re-stage after commit) |
YAML (.yaml, .yml)
| Hook ID | Repo | Rev | Rationale |
|---|---|---|---|
check-yaml |
https://github.com/pre-commit/pre-commit-hooks |
v6.0.0 |
Validates YAML parses correctly |
For Kubernetes/Helm YAML with custom tags, add args: ['--unsafe'] and exclude: ^helm/templates/.
TOML (.toml)
| Hook ID | Repo | Rev | Rationale |
|---|---|---|---|
check-toml |
https://github.com/pre-commit/pre-commit-hooks |
v6.0.0 |
Validates TOML parses correctly |
Secrets / security
| Hook ID | Repo | Rev | Rationale |
|---|---|---|---|
gitleaks |
https://github.com/gitleaks/gitleaks |
v8.30.1 |
Unverified — not in research corpus, verify upstream before use. Scans for secrets and high-entropy strings |
Commit message
| Hook ID | Repo | Rev | Stage | Rationale |
|---|---|---|---|---|
conventional-pre-commit |
https://github.com/compilerla/conventional-pre-commit |
v2.4.0 |
commit-msg |
Enforces Conventional Commits format |
When adding commit-msg hooks, also add default_install_hook_types: [pre-commit, commit-msg] to the top-level config if not already present.
Meta-validation (add last, after all other repos)
- repo: meta
hooks:
- id: check-hooks-apply # catches hooks that match no files
- id: check-useless-excludes # catches exclude patterns that match no files
Local hooks (repo: local)
Use for repo-specific scripts that don't belong in an external hook repo.
- repo: local
hooks:
- id: run-tests
name: Run test suite
entry: bash tests/run-tests.sh
language: unsupported_script
pass_filenames: false
always_run: true
stages: [pre-push]
language: system and language: script are deprecated names for the first two below.
New local hooks use unsupported and unsupported_script.
Language choices for local hooks:
unsupported— system PATH tool (pre-commit does not manage env)unsupported_script— script at a repo-relative pathfail— always-fail guard;entrytext becomes the error messagepython— isolated venv; useadditional_dependenciesfor pip packagesnode— isolated node env;additional_dependenciesare npm packagesruby— isolated gem env;additional_dependenciesare gemsgolang— builds from source;additional_dependenciesare Go module pathsrust— Cargo builddocker— Docker image built fromentry; use when no other language fitsdocker_image— pulls a pre-built Docker image byentryconda— Conda environment; conda-native hookscoursier— Coursier (Scala/JVM) environment; JVM hooks
Rev pin freshness
The revs above were last verified current at time of writing (matched against the plugin's own research corpus in docs/research/docs/pre-commit/; rows marked "Unverified" have no such backing and must be checked against upstream before use). Since the "Rev staleness" check in references/modify-config.md treats this table as ground truth, a pin that goes stale here produces false-positive staleness warnings for users who already have a newer, correct rev. Re-verify these pins periodically (e.g. against each repo's latest release tag). When in doubt, treat pre-commit autoupdate's own output as the authoritative staleness signal, not a mismatch against this table.