Defame1297
5e232503c4
Why: ADR-0015 established that Microsoft APM (apm.yml + .apm/) should replace this repo's hand-authored plugin.json/marketplace.json model, with those files becoming compiled output of `apm pack` instead of files edited by hand via the (now-retired) plugin-author/marketplace-author skills. Issue #90 was the deferred execution of that decision, gated on #88 (apm tooling) and #89 (apm-native agent-author/skill-author routing). Implementation notes: - All six plugins (bin, core, git, gitea, kyberforge, lint) now carry apm.yml + .apm/{skills,agents,hooks} as their authoring source. Skills moved with a plain git mv (content-identical across targets). Agents were re-authored, not moved: per ADR-0016, .apm/agents/*.agent.md compiles verbatim to both Claude and Copilot, so plugin-scope agents now carry only name/description/model/source_keys -- no tools: field, no Claude-only knobs (isolation, maxTurns, effort, memory, permissionMode). - Root apm.yml registers all 7 marketplace packages (6 local plus mattpocock-skills as a remote entry) under versioning: per_package, matching this repo's existing independent-plugin-versioning practice. - .claude-plugin/marketplace.json and every plugin's plugin.json are now apm-pack-compiled output, verified against the prior hand-maintained content: same names/descriptions/versions/licenses/authors, only cosmetic serialization differences (JSON key order, owner email vs. url, Unicode escaping). - plugin-author and marketplace-author are retired now that apm-based authoring fully replaces their job; kyberforge bumped 1.3.1 -> 1.4.0 for that removal, and the root marketplace catalog bumped 0.3.1 -> 0.3.2 to match, per the version-bump convention now documented in apm-workflow's reference docs instead of a dedicated script (apm has no native version-bump automation). - Fixed hardcoded pre-.apm/ path assumptions across .pre-commit-config.yaml, .pre-commit-hooks.yaml, scripts/check-scope-walkup-sync.sh, scripts/sync-vale-styles.sh, scripts/check-vale-style-sync.sh, six plugins' root plugin.json (stale skills/hooks/agents pointer fields that check-manifests.sh validates), and several tests/*.bats and tests/*.sh fixtures -- including a bats REPO_ROOT relative-path depth bug (10 files, one extra .apm/ directory level to walk up) and a vale probe-path isolation regression introduced mid-fix. - Corrected empirically-wrong assumptions surfaced this session in apm-workflow/apm-install's own reference docs: `apm marketplace package add` does not accept local paths (only owner/repo remote shorthand -- local packages are registered by editing apm.yml's marketplace.packages[] directly); `apm compile` is a consumer-side AGENTS.md/CLAUDE.md generator, not the plugin.json producer, and hard-fails on skill/agent-only packages without --clean; `apm plugin init <name>` nests a stray subdirectory when run with a positional name arg from inside a same-named directory; no native Copilot marketplace output profile exists; .mcp.json is merged into the compiled plugin.json content-aware and target-scoped, with no dependencies.mcp entry needed for simple passthrough; pipx is the correct pip fallback on externally-managed Python environments. - Renamed agent-author's copilot.agent.md template asset to copilot.agent.md.template so apm compile's recursive *.agent.md glob stops misparsing the placeholder template as a real agent primitive. Impact: plugin.json and marketplace.json are compiled artifacts from here on -- editing them by hand is no longer the workflow; edit apm.yml/.apm/ and run apm pack. CONTEXT.md's Plugin/Plugin marketplace glossary entries reflect this. ADR-0001 is marked superseded, ADR-0006 moot, and ADR-0010 updated for the new .apm/agents/ path (project/user scope unaffected, per ADR-0016). Full local verification: claude plugin validate --strict on all 6 plugins, apm audit --ci, apm marketplace check, check-manifests.sh, and the full test suite (165/165 bats, 13/13 shell scripts) all pass clean. Fixes: #90 Refs: #88, #89 ADR: 0015 ADR: 0016 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ub96PyaSRD9BHPktotj1pC
171 lines
4.9 KiB
Markdown
171 lines
4.9 KiB
Markdown
---
|
|
source_keys:
|
|
- conventional-commits-spec
|
|
- commitlint-config-conventional
|
|
---
|
|
|
|
# Conventional Commits Specification (v1.0.0)
|
|
|
|
Conventional Commits is a lightweight convention on top of commit messages that provides a set of rules for creating an explicit commit history. It enables automated tooling (CHANGELOG generation, semantic version bumping) and structured filtering.
|
|
|
|
## Message Format
|
|
|
|
```
|
|
<type>[optional scope]: <description>
|
|
|
|
[optional body]
|
|
|
|
[optional footer(s)]
|
|
```
|
|
|
|
Each section is separated by a blank line. The header is the only required part.
|
|
|
|
## Rules
|
|
|
|
| Element | Rule |
|
|
|---|---|
|
|
| `type` | Required. Lowercase noun. |
|
|
| `scope` | Optional. Noun in parentheses directly after type: `feat(api):`. |
|
|
| `description` | Required. Immediately follows `type/scope: `. Imperative mood, no trailing period. |
|
|
| `body` | Optional. Begins one blank line after description. Free-form prose, multiple paragraphs allowed. Lines max 100 characters. |
|
|
| `footer(s)` | Optional. Begins one blank line after body (or description). `<token>: <value>` format. Lines max 100 characters. |
|
|
| `BREAKING CHANGE` | Must be uppercase. Either a footer token or signalled by `!` before the colon. |
|
|
|
|
## Standard Types
|
|
|
|
The spec itself mandates only `feat` and `fix`. The 11-type set below is the de-facto standard from `@commitlint/config-conventional` (Angular commit message guidelines), not a spec requirement — but it is what this skill validates against.
|
|
|
|
### 11-type set (commitlint/config-conventional)
|
|
|
|
| Type | Meaning | SemVer impact | Appears in CHANGELOG |
|
|
|---|---|---|---|
|
|
| `feat` | New user-visible feature | MINOR | Yes |
|
|
| `fix` | Bug fix | PATCH | Yes |
|
|
| `perf` | Performance improvement, no API change | PATCH | Yes |
|
|
| `revert` | Reverts a previous commit | PATCH | Yes |
|
|
| `docs` | Documentation only | none | No |
|
|
| `style` | Formatting, whitespace — no logic change | none | No |
|
|
| `refactor` | Code restructuring — no feature or fix | none | No |
|
|
| `test` | Adding or fixing tests | none | No |
|
|
| `build` | Build system or external dependency changes | none | No |
|
|
| `ci` | CI configuration and scripts | none | No |
|
|
| `chore` | Anything not fitting above | none | No |
|
|
|
|
A `BREAKING CHANGE` footer or `!` on **any** type always triggers a MAJOR bump.
|
|
|
|
## Breaking Changes
|
|
|
|
Two equivalent notations:
|
|
|
|
**`!` in header** (preferred — visible in `git log --oneline`):
|
|
```
|
|
feat!: drop support for Node 6
|
|
feat(api)!: remove deprecated endpoint
|
|
```
|
|
|
|
**`BREAKING CHANGE` footer** (machine-readable body):
|
|
```
|
|
feat: allow config to extend other configs
|
|
|
|
BREAKING CHANGE: `extends` key now used for extending config files
|
|
```
|
|
|
|
**Both together** (most explicit):
|
|
```
|
|
feat!: drop support for Node 6
|
|
|
|
BREAKING CHANGE: use JavaScript features not available in Node 6.
|
|
```
|
|
|
|
Rules:
|
|
- `BREAKING CHANGE` must be all caps.
|
|
- `BREAKING-CHANGE` (hyphenated) is an accepted synonym.
|
|
- Any type can carry a breaking change, not just `feat`.
|
|
- The footer value must describe what broke.
|
|
|
|
## Footer Token Rules
|
|
|
|
```
|
|
<token>: <value>
|
|
<token> #<value> # for issue references
|
|
```
|
|
|
|
- Tokens use hyphens for word separation: `Reviewed-by`, `Co-authored-by`, `Refs`.
|
|
- Exception: `BREAKING CHANGE` (space allowed, uppercase).
|
|
- Multiple footers allowed, one per line.
|
|
- Blank line required before the footer block.
|
|
|
|
Valid footer examples:
|
|
```
|
|
Reviewed-by: Z
|
|
Refs: #123
|
|
Co-authored-by: Alice <alice@example.com>
|
|
BREAKING CHANGE: the `--format` flag now requires a value
|
|
```
|
|
|
|
## Examples
|
|
|
|
Minimal — no body, no footer:
|
|
```
|
|
docs: correct spelling of CHANGELOG
|
|
```
|
|
|
|
With scope:
|
|
```
|
|
feat(lang): add Polish language
|
|
```
|
|
|
|
Breaking change via `!`:
|
|
```
|
|
feat!: send an email to the customer when a product is shipped
|
|
```
|
|
|
|
Breaking change via footer:
|
|
```
|
|
feat: allow provided config object to extend other configs
|
|
|
|
BREAKING CHANGE: `extends` key in config file is now used for extending other config files
|
|
```
|
|
|
|
Multi-paragraph body with multiple footers:
|
|
```
|
|
fix: prevent racing of requests
|
|
|
|
Introduce a request id and a reference to latest request. Dismiss
|
|
incoming responses other than from latest request.
|
|
|
|
Remove timeouts which were used to mitigate the racing issue but are
|
|
obsolete now.
|
|
|
|
Reviewed-by: Z
|
|
Refs: #123
|
|
```
|
|
|
|
Revert:
|
|
```
|
|
revert: let us never again speak of the noodle incident
|
|
|
|
Refs: 676104e, a215868
|
|
```
|
|
|
|
## commitlint Constraints (config-conventional)
|
|
|
|
| Constraint | Value |
|
|
|---|---|
|
|
| Header max length | 100 characters |
|
|
| Subject must not end with `.` | enforced |
|
|
| Subject must be lowercase (not sentence-case or UPPER-CASE) | enforced |
|
|
| Body / footer line max length | 100 characters |
|
|
| Type must be one of the 11 standard types | error if not |
|
|
| Blank line before body | warning |
|
|
| Blank line before footer | warning |
|
|
|
|
## SemVer Mapping Summary
|
|
|
|
| Condition | SemVer bump |
|
|
|---|---|
|
|
| `fix`, `perf`, `revert` | PATCH |
|
|
| `feat` | MINOR |
|
|
| Any type with `BREAKING CHANGE` or `!` | MAJOR |
|
|
| All other types (`docs`, `style`, `refactor`, `test`, `build`, `ci`, `chore`) | none |
|