Retrofits all 39 skills to ADR-0020's description/body context contract, then fixes what six rounds of independent review found in that retrofit — including four ways the hot gate itself failed open. Closes #99, #107, #108, #110, #111, #114, #115, #120. ## The retrofit (waves 1-5) | | Start | Now | |---|---|---| | Description FAILs (>400 chars) | 26 | **0** | | Body FAILs (>900 words, body-only) | 9 | **0** | | Dangling routing targets | 2 | **0** | | `Kyberforge.CompositionNote` | 10 | **0** | | Preload tax | 21,005 chars | **~10,500** | Under the 12,000-char success criterion. Per-wave detail is on #99. ## The review fixes **The gate failed open four ways, three of them found after the retrofit shipped.** An unrecognised follower token made a dangling target vanish. A skill directory with no `SKILL.md` resolved as a valid target, so a commit could be green locally and red in a fresh clone — three existing fixtures were relying on that, one of which made the install-leak A/B pass vacuously. Then the free-standing `/name` sweep turned out to be gated on the sentence carrying a boundary marker, so route notation in any other sentence was invisible — not an ERROR, not a SUGGESTION, not an INFO — which left the documented "`/name` always blocks" promise false from a second direction. All four fixed and pinned. **Two checks were silently not running.** `validate-provenance.sh` checks 7-8 were dead across nine skills. Waking them exposed a deeper problem: they assume `Research doc:` names a source index, but 30 of 121 entries point at topic content documents, so every new check-7 INFO was a false positive and check 8 was saved from a false-FAIL flood only by an *unannounced* skip. Checks 7/8 are now scoped to source indexes and every skip announces itself (#121). **The retrofit's own anti-goal, four times.** ADR-0020 warns that a blunt gate gets satisfied by deleting content rather than relocating it. `diagnose` and `skill-audit` relocated prose and then read it unconditionally; `prototype` and `vale-config` deleted rules outright that survived nowhere. All four addressed. ## Verification - `bash tests/run-tests.sh --strict` — 24 suites, 0 skipped, 0 failed - `bash tests/run-bats.sh` — 325 tests, 0 failures - `pre-commit run --all-files` — 17/17 - `pre-commit run --hook-stage pre-push --all-files` — 16/16, with `apm marketplace check` and `apm pack --check-clean` run against the remote, not skipped - `scripts/skill-size-check.sh` over all 39 skills — rc 0, 0 ERROR/FAIL, SUGGESTION-only - Preload tax measured at **10,498 chars**, max description 390 — both inside budget - Every new test proven non-vacuous by a deliberate mutation of the behaviour it covers **Per-commit sync, stated accurately:** the ten commits from the latest review round each pass `check-plugin-content-sync` in isolation, verified by checking each out in a detached worktree with a clean between. The earlier gitea window (`dfacf05..bedbd1d`, nine commits) does **not** — its mirror was regenerated in one batch at `bbc7300`. An earlier revision of this description claimed the property held for every commit; it does not, and a bisect through that window lands on a red commit. **Squash-merge** to collapse it, or accept that this range is not bisectable. ## Version bump Six plugins and the catalog take a **patch**, not a minor. The branch is **89 commits — 40 `fix` / 30 `refactor` / 12 `docs` / 5 `chore` / 2 `test` — zero `feat`, zero `!`, zero `BREAKING CHANGE`** — and adds no skill, agent, command or hook. (Two earlier revisions of this section cited a stale histogram, most recently 78 commits; the figures above are measured at HEAD.) Both rules this repo ships (`forge/references/version-bump.md`, landing in this PR, and `git-commits/references/conventional-commits-spec.md`) make that a patch, and the catalog set is unchanged at 7 entries. Not settled by that: four published files were removed from the installed tree, three moved, and `caveman` gained `disable-model-invocation`, retiring its old triggers. Under a strict reading those are major-class and currently ship under `refactor:` with no marker. Whether the deployed skill surface is a public contract is written down nowhere — worth deciding, but it outlives this PR. ## Deliberately not in scope #112 (cherry-pick ownership, now resolved in favour of `git-commits`), #113 (`rtk git` normalisation), #116 (research fan-out), #101 (audit-skill merge), #122 (non-spec skill-root files), #123 (no PRD producer) stay open. #117 is the one worth reading: the contract's remedy is to move prose into `references/`, which is exactly where neither the size gate nor Vale looks — and the blind spot is wider than #117 currently records, since there is no root `.vale.ini` at all, so every ADR, `CONTEXT.md` and `README.md` is unlinted too. That blind spot let this branch carry two `level: error` `Kyberforge.SentenceOpenerThereIs` violations into `references/` files it created — `provider-adapter-author/references/provider-matrix.md:31` and `agent-audit/references/finding-criteria.md:95`. Both are reworded in `afadaae`, confirmed by routing each file through the audit's own `vale-wrap.sh` (1 error each before, 0 after). Five further occurrences sit in `references/` files already on `main`; those are the pre-existing corpus and stay with #117, which is the real fix. Also unfixed and not this PR's: `apm install` appends a duplicate `SessionStart` entry to `.claude/settings.json`, so a fresh clone cannot get pre-push green without an edit AGENTS.md warns against. Reproduces identically on `main`. Co-authored-by: Defame1297 <gitea@rkdr.net> Reviewed-on: https://git.dev.rkdr.net/Defame1297/holocron/pulls/129 Co-authored-by: Claude Code AI - Gitea MCP <claude@noreply.git.dev.rkdr.net> Co-committed-by: Claude Code AI - Gitea MCP <claude@noreply.git.dev.rkdr.net>
169 lines
6.1 KiB
Markdown
169 lines
6.1 KiB
Markdown
# Writing Agent Briefs
|
|
|
|
An agent brief is a structured comment posted on an issue in the issue tracker when it moves to `ready-for-agent`. It is the authoritative specification that an AFK agent will work from. The original issue body and discussion are context — the agent brief is the contract.
|
|
|
|
## Principles
|
|
|
|
### Durability over precision
|
|
|
|
The issue may sit in `ready-for-agent` for days or weeks. The codebase will change in the meantime. Write the brief so it stays useful even as files are renamed, moved, or refactored.
|
|
|
|
- **Do** describe interfaces, types, and behavioral contracts
|
|
- **Do** name specific types, function signatures, or config shapes that the agent should look for or modify
|
|
- **Don't** reference file paths — they go stale
|
|
- **Don't** reference line numbers
|
|
- **Don't** assume the current implementation structure will remain the same
|
|
|
|
### Behavioral, not procedural
|
|
|
|
Describe **what** the system should do, not **how** to implement it. The agent will explore the codebase fresh and make its own implementation decisions.
|
|
|
|
- **Good:** "The `SkillConfig` type should accept an optional `schedule` field of type `CronExpression`"
|
|
- **Bad:** "Open src/types/skill.ts and add a schedule field on line 42"
|
|
- **Good:** "When a user runs `/triage` with no arguments, they should see a summary of issues needing attention"
|
|
- **Bad:** "Add a switch statement in the main handler function"
|
|
|
|
### Complete acceptance criteria
|
|
|
|
The agent needs to know when it's done. Every agent brief must have concrete, testable acceptance criteria. Each criterion should be independently verifiable.
|
|
|
|
- **Good:** "Querying the issue tracker for the `needs-triage` label returns issues that have been through initial classification"
|
|
- **Bad:** "Triage should work correctly"
|
|
|
|
### Explicit scope boundaries
|
|
|
|
State what is out of scope. This prevents the agent from gold-plating or making assumptions about adjacent features.
|
|
|
|
## Template
|
|
|
|
```markdown
|
|
## Agent Brief
|
|
|
|
**Category:** bug / enhancement
|
|
**Summary:** one-line description of what needs to happen
|
|
|
|
**Current behavior:**
|
|
Describe what happens now. For bugs, this is the broken behavior.
|
|
For enhancements, this is the status quo the feature builds on.
|
|
|
|
**Desired behavior:**
|
|
Describe what should happen after the agent's work is complete.
|
|
Be specific about edge cases and error conditions.
|
|
|
|
**Key interfaces:**
|
|
- `TypeName` — what needs to change and why
|
|
- `functionName()` return type — what it currently returns vs what it should return
|
|
- Config shape — any new configuration options needed
|
|
|
|
**Acceptance criteria:**
|
|
- [ ] Specific, testable criterion 1
|
|
- [ ] Specific, testable criterion 2
|
|
- [ ] Specific, testable criterion 3
|
|
|
|
**Out of scope:**
|
|
- Thing that should NOT be changed or addressed in this issue
|
|
- Adjacent feature that might seem related but is separate
|
|
```
|
|
|
|
## Examples
|
|
|
|
### Good agent brief (bug)
|
|
|
|
```markdown
|
|
## Agent Brief
|
|
|
|
**Category:** bug
|
|
**Summary:** Skill description truncation drops mid-word, producing broken output
|
|
|
|
**Current behavior:**
|
|
When a skill description exceeds 1024 characters, it is truncated at exactly
|
|
1024 characters regardless of word boundaries. This produces descriptions
|
|
that end mid-word (e.g. "Use when the user wants to confi").
|
|
|
|
**Desired behavior:**
|
|
Truncation should break at the last word boundary before 1024 characters
|
|
and append "..." to indicate truncation.
|
|
|
|
**Key interfaces:**
|
|
- The `SkillMetadata` type's `description` field — no type change needed,
|
|
but the validation/processing logic that populates it needs to respect
|
|
word boundaries
|
|
- Any function that reads SKILL.md frontmatter and extracts the description
|
|
|
|
**Acceptance criteria:**
|
|
- [ ] Descriptions under 1024 chars are unchanged
|
|
- [ ] Descriptions over 1024 chars are truncated at the last word boundary
|
|
before 1024 chars
|
|
- [ ] Truncated descriptions end with "..."
|
|
- [ ] The total length including "..." does not exceed 1024 chars
|
|
|
|
**Out of scope:**
|
|
- Changing the 1024 char limit itself
|
|
- Multi-line description support
|
|
```
|
|
|
|
### Good agent brief (enhancement)
|
|
|
|
```markdown
|
|
## Agent Brief
|
|
|
|
**Category:** enhancement
|
|
**Summary:** Add `.out-of-scope/` directory support for tracking rejected feature requests
|
|
|
|
**Current behavior:**
|
|
When a feature request is rejected, the issue is closed with a `wontfix` label
|
|
and a comment. There is no persistent record of the decision or reasoning.
|
|
Future similar requests require the maintainer to recall or search for the
|
|
prior discussion.
|
|
|
|
**Desired behavior:**
|
|
Rejected feature requests should be documented in `.out-of-scope/<concept>.md`
|
|
files that capture the decision, reasoning, and links to all issues that
|
|
requested the feature. When triaging new issues, these files should be
|
|
checked for matches.
|
|
|
|
**Key interfaces:**
|
|
- Markdown file format in `.out-of-scope/` — each file should have a
|
|
`# Concept Name` heading, a `**Decision:**` line, a `**Reason:**` line,
|
|
and a `**Prior requests:**` list with issue links
|
|
- The triage workflow should read all `.out-of-scope/*.md` files early
|
|
and match incoming issues against them by concept similarity
|
|
|
|
**Acceptance criteria:**
|
|
- [ ] Closing a feature as wontfix creates/updates a file in `.out-of-scope/`
|
|
- [ ] The file includes the decision, reasoning, and link to the closed issue
|
|
- [ ] If a matching `.out-of-scope/` file already exists, the new issue is
|
|
appended to its "Prior requests" list rather than creating a duplicate
|
|
- [ ] During triage, existing `.out-of-scope/` files are checked and surfaced
|
|
when a new issue matches a prior rejection
|
|
|
|
**Out of scope:**
|
|
- Automated matching (human confirms the match)
|
|
- Reopening previously rejected features
|
|
- Bug reports (only enhancement rejections go to `.out-of-scope/`)
|
|
```
|
|
|
|
### Bad agent brief
|
|
|
|
```markdown
|
|
## Agent Brief
|
|
|
|
**Summary:** Fix the triage bug
|
|
|
|
**What to do:**
|
|
The triage thing is broken. Look at the main file and fix it.
|
|
The function around line 150 has the issue.
|
|
|
|
**Files to change:**
|
|
- src/triage/handler.ts (line 150)
|
|
- src/types.ts (line 42)
|
|
```
|
|
|
|
This is bad because:
|
|
- No category
|
|
- Vague description ("the triage thing is broken")
|
|
- References file paths and line numbers that will go stale
|
|
- No acceptance criteria
|
|
- No scope boundaries
|
|
- No description of current vs desired behavior
|