Retrofits all 39 skills to ADR-0020's description/body context contract, then fixes what six rounds of independent review found in that retrofit — including four ways the hot gate itself failed open. Closes #99, #107, #108, #110, #111, #114, #115, #120. ## The retrofit (waves 1-5) | | Start | Now | |---|---|---| | Description FAILs (>400 chars) | 26 | **0** | | Body FAILs (>900 words, body-only) | 9 | **0** | | Dangling routing targets | 2 | **0** | | `Kyberforge.CompositionNote` | 10 | **0** | | Preload tax | 21,005 chars | **~10,500** | Under the 12,000-char success criterion. Per-wave detail is on #99. ## The review fixes **The gate failed open four ways, three of them found after the retrofit shipped.** An unrecognised follower token made a dangling target vanish. A skill directory with no `SKILL.md` resolved as a valid target, so a commit could be green locally and red in a fresh clone — three existing fixtures were relying on that, one of which made the install-leak A/B pass vacuously. Then the free-standing `/name` sweep turned out to be gated on the sentence carrying a boundary marker, so route notation in any other sentence was invisible — not an ERROR, not a SUGGESTION, not an INFO — which left the documented "`/name` always blocks" promise false from a second direction. All four fixed and pinned. **Two checks were silently not running.** `validate-provenance.sh` checks 7-8 were dead across nine skills. Waking them exposed a deeper problem: they assume `Research doc:` names a source index, but 30 of 121 entries point at topic content documents, so every new check-7 INFO was a false positive and check 8 was saved from a false-FAIL flood only by an *unannounced* skip. Checks 7/8 are now scoped to source indexes and every skip announces itself (#121). **The retrofit's own anti-goal, four times.** ADR-0020 warns that a blunt gate gets satisfied by deleting content rather than relocating it. `diagnose` and `skill-audit` relocated prose and then read it unconditionally; `prototype` and `vale-config` deleted rules outright that survived nowhere. All four addressed. ## Verification - `bash tests/run-tests.sh --strict` — 24 suites, 0 skipped, 0 failed - `bash tests/run-bats.sh` — 325 tests, 0 failures - `pre-commit run --all-files` — 17/17 - `pre-commit run --hook-stage pre-push --all-files` — 16/16, with `apm marketplace check` and `apm pack --check-clean` run against the remote, not skipped - `scripts/skill-size-check.sh` over all 39 skills — rc 0, 0 ERROR/FAIL, SUGGESTION-only - Preload tax measured at **10,498 chars**, max description 390 — both inside budget - Every new test proven non-vacuous by a deliberate mutation of the behaviour it covers **Per-commit sync, stated accurately:** the ten commits from the latest review round each pass `check-plugin-content-sync` in isolation, verified by checking each out in a detached worktree with a clean between. The earlier gitea window (`dfacf05..bedbd1d`, nine commits) does **not** — its mirror was regenerated in one batch at `bbc7300`. An earlier revision of this description claimed the property held for every commit; it does not, and a bisect through that window lands on a red commit. **Squash-merge** to collapse it, or accept that this range is not bisectable. ## Version bump Six plugins and the catalog take a **patch**, not a minor. The branch is **89 commits — 40 `fix` / 30 `refactor` / 12 `docs` / 5 `chore` / 2 `test` — zero `feat`, zero `!`, zero `BREAKING CHANGE`** — and adds no skill, agent, command or hook. (Two earlier revisions of this section cited a stale histogram, most recently 78 commits; the figures above are measured at HEAD.) Both rules this repo ships (`forge/references/version-bump.md`, landing in this PR, and `git-commits/references/conventional-commits-spec.md`) make that a patch, and the catalog set is unchanged at 7 entries. Not settled by that: four published files were removed from the installed tree, three moved, and `caveman` gained `disable-model-invocation`, retiring its old triggers. Under a strict reading those are major-class and currently ship under `refactor:` with no marker. Whether the deployed skill surface is a public contract is written down nowhere — worth deciding, but it outlives this PR. ## Deliberately not in scope #112 (cherry-pick ownership, now resolved in favour of `git-commits`), #113 (`rtk git` normalisation), #116 (research fan-out), #101 (audit-skill merge), #122 (non-spec skill-root files), #123 (no PRD producer) stay open. #117 is the one worth reading: the contract's remedy is to move prose into `references/`, which is exactly where neither the size gate nor Vale looks — and the blind spot is wider than #117 currently records, since there is no root `.vale.ini` at all, so every ADR, `CONTEXT.md` and `README.md` is unlinted too. That blind spot let this branch carry two `level: error` `Kyberforge.SentenceOpenerThereIs` violations into `references/` files it created — `provider-adapter-author/references/provider-matrix.md:31` and `agent-audit/references/finding-criteria.md:95`. Both are reworded in `afadaae`, confirmed by routing each file through the audit's own `vale-wrap.sh` (1 error each before, 0 after). Five further occurrences sit in `references/` files already on `main`; those are the pre-existing corpus and stay with #117, which is the real fix. Also unfixed and not this PR's: `apm install` appends a duplicate `SessionStart` entry to `.claude/settings.json`, so a fresh clone cannot get pre-push green without an edit AGENTS.md warns against. Reproduces identically on `main`. Co-authored-by: Defame1297 <gitea@rkdr.net> Reviewed-on: https://git.dev.rkdr.net/Defame1297/holocron/pulls/129 Co-authored-by: Claude Code AI - Gitea MCP <claude@noreply.git.dev.rkdr.net> Co-committed-by: Claude Code AI - Gitea MCP <claude@noreply.git.dev.rkdr.net>
106 lines
5.5 KiB
Markdown
106 lines
5.5 KiB
Markdown
---
|
|
source_keys:
|
|
- context7-websites-code-claude
|
|
- claude-code-plugins-docs
|
|
- claude-code-subagents-docs
|
|
- context7-github-en-copilot
|
|
- github-custom-agents-configuration
|
|
---
|
|
|
|
# Body, Delegation and Comment Discipline Reference
|
|
|
|
Upstream source: Claude Code subagent and plugin references, GitHub Copilot custom-agents
|
|
configuration. House contract: ADR-0020, the context budget.
|
|
|
|
Read this when judging the **body**, **delegation** and **comment-discipline** dimensions.
|
|
|
|
## The core test
|
|
|
|
For every sentence in the body, ask: **"Would the agent get this wrong without this instruction?"**
|
|
|
|
If no — cut it. The agent already knows it from general training. Adding it wastes tokens and
|
|
dilutes the signal of what matters.
|
|
|
|
## Agents take no body word gate
|
|
|
|
ADR-0020 gates a skill body at 600 words SUGGESTION / 900 FAIL and deliberately gates an agent body
|
|
at nothing. The two are not the same construct: a skill body is loaded into the caller's live
|
|
context and competes with the conversation already there, while an agent body *becomes* the system
|
|
prompt of a fresh context that has nothing else in it. The rationale for the 900-word ceiling does
|
|
not transfer, so:
|
|
|
|
- **Never report an agent body as too long on a word count.** There is no number to cite.
|
|
- **Never add such a gate to `scripts/validate.sh`.** `tests/validate.bats` pins its absence with a
|
|
body far past 900 words that must still pass, and adding one would contradict the ADR.
|
|
- The one length signal that does apply is the Copilot runtime's 30,000-character body limit, which
|
|
`validate.sh` already reports as a SUGGESTION because content past it is silently truncated.
|
|
|
|
Length is judged through the delegation check below instead, which is the defect a word count was
|
|
standing in for anyway.
|
|
|
|
## The delegation check
|
|
|
|
A plugin-scope agent is a single `.apm/agents/<name>.agent.md` file with no sibling `references/`
|
|
directory. It cannot progressively disclose to itself — it can only delegate to skills. So a
|
|
procedure spelled out in an agent body that a skill the agent invokes already owns is not a
|
|
shortcut: it is a second copy of that procedure, and the second copy drifts. This is the
|
|
characteristic agent defect, the way a stale README row is the characteristic skill defect.
|
|
|
|
**An agent body that restates a procedure owned by a skill it can invoke is a FAIL.** The Fix is
|
|
always the same shape: invoke `<skill>` instead.
|
|
|
|
How to apply it: for each procedural block in the body — a rule list, a numbered sequence, a
|
|
constraint table — ask which skill owns that procedure. If the agent names that skill anywhere (its
|
|
dispatch table, its routing prose, its frontmatter), the block is a restatement and the skill is
|
|
already there to be invoked.
|
|
|
|
Worked example. The three `*-orchestrate` agents exist to compose domain skills — `git-orchestrate`
|
|
(933 body words), `gitea-orchestrate` (1,199) and `apm-orchestrate` (1,080) — so any step they
|
|
spell out that the composed skill already owns is the defect. `git-orchestrate:24-31` carries a
|
|
"Hard rules" list (Conventional Commits types, atomic commits, never commit secrets, git trailers)
|
|
that `git-commits` owns and that `git-orchestrate:44` routes to by name; `:39` concedes the point
|
|
outright, noting the sub-skills "carry their own local copies of these rules". Two copies, one
|
|
authority, and nothing keeping them in step.
|
|
|
|
What is **not** a finding under this rule, because no skill owns it:
|
|
|
|
- The dispatch table itself — which operation routes to which skill.
|
|
- Safety gates the agent enforces before dispatching, and refusals it makes on its own authority.
|
|
- The input contract and the structured output the agent's caller consumes.
|
|
- Session state the agent carries across skill invocations.
|
|
|
|
## What the body is for
|
|
|
|
Include what the fresh context lacks:
|
|
|
|
- A direct role instruction opening the prompt: `You are a [role]. When invoked, [action].`
|
|
- One bounded job, stated so the agent knows what it must refuse.
|
|
- The dispatch, gates, inputs and outputs listed above.
|
|
- **Error handling** — what the agent does on malformed, missing or contradictory input: stop and
|
|
report, or degrade to a named fallback. Absent it, the agent invents a recovery, and a
|
|
subagent's invented recovery is invisible to its caller until the output is wrong.
|
|
- Non-obvious environment facts and project-specific conventions it cannot infer.
|
|
- One default per decision point with one escape hatch.
|
|
|
|
Do not include at all:
|
|
|
|
- Concepts the agent already knows (what JSON is, how HTTP works, what a CSV is)
|
|
- Exhaustive option lists — pick a default; the agent does not benefit from choosing
|
|
- Steps the agent handles independently — over-specifying leads to unproductive paths
|
|
- Restatements of the description, which is already in context
|
|
|
|
## Comment discipline
|
|
|
|
Inspect every comment block in the YAML frontmatter and apply the core test to each: *would the
|
|
agent get this wrong without this comment?* Template scaffolding — `# Optional. <long
|
|
explanation>`, more than a line or two of inline guidance per field — belongs to development, not
|
|
to a shipped file. At plugin/APM scope the stakes are higher than tidiness: `apm compile` copies
|
|
frontmatter verbatim to every target, `<!-- ... -->` is not valid YAML, and `validate.sh` FAILs a
|
|
frontmatter block that still contains one.
|
|
|
|
## Where the criteria live
|
|
|
|
Every FAIL and SUGGESTION criterion for these dimensions is in `references/finding-criteria.md`,
|
|
which Step 3 reads on every run. This file is the reasoning behind them, loaded only when that file
|
|
puts the body, delegation or comment-discipline dimension in play.
|